move_dep_from_module_run #58701
Merged
move_dep_from_module_run #58701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
cmcmarrow
added a commit
that referenced
this pull request
Oct 9, 2020
cdalvaro
added a commit
to cdalvaro/salt
that referenced
this pull request
Oct 12, 2020
…st_command * github/master: (657 commits) Update botocore to the latest 1.16.26 release Revert "move_dep_from_module_run (saltstack#58701)" (saltstack#58702) move_dep_from_module_run (saltstack#58701) Update 3002.rst Update 3002.rst Update 3002.rst Update 3002.rst Update 3002.rst Update 3002.rst Update Releasenotes 3002 Update Changelog 3002 Update index.rst Update Reference Magnsium Skip tests depending on the `ssl_webserver` fixture if on Py < 3.5.3 Update man-pages to 3002 Update RC Install Instructions Fix rst formatting Refresh README; add SECURITY; update logos Revert "Set the codepage on windows at import time of `salt/utils/parsers.py`" Set the codepage on windows at import time of `salt/utils/parsers.py` ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Salt no longer wants to deprecate module.run. This is because the new way of doing is missing some functionality as well its move complex and has a sharper learning curve.
What issues does this PR fix or reference?
Fixes:
Previous Behavior
module.run has a deprecation warring
New Behavior
module.run does not have a deprecation warring
Merge requirements satisfied?
Commits signed with GPG?
Yes