Report failures and error information from tuned module #60534
Conversation
Replace stdout in cases of success with known value for state to evaluate. Update response handling in states. Fixes saltstack#60500
|
Closing this due to inactivity. Anyone should feel free to re-open it if they want to see it through to the end in one release cycle. |
|
@dwoz can you clarify what you mean by Abandoned? I don't see any feedback from SaltStack beyond tags and being Approved in 2021. |
|
@leeclemens We are making an effort to clean up out-dated PRs. This was closed purely because there was no activity in 2 years. If you want to get it into a release please rebase and re-open the PR. We'll get it in. |
|
@dwoz thanks for the feedback. I suppose I was confused by the "if they want to see it through to the end in one release cycle" comment since you closing the PR was the first feedback I received on either the Issue or the PR created over 2 years ago. The PR was submitted 3 days after opening the Issue. I also marked this PR for review and the first response was to close it as Abandoned. |
|
It seems like the rebase issue was that the tests were moved to pytests about 1.5 years after the PR was created. I copied them and submitted #65720 . |
Replace stdout in cases of success with known value for state to evaluate.
Update response handling in states.
What does this PR do?
Returns cmd results from module for better processing and error handling.
What issues does this PR fix or reference?
Fixes: #60500
Previous Behavior
Errors were ignored and cmd output was ignored, specifically from the state. State was reported as successful/changed in some failed executions.
New Behavior
The module returns the full output from the cmd and modifies it when useful (success with the new expected profile being returned in stdout). Report failed execution as failure back to state.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.