avoids crash on cache corruption #61356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcmarrow
requested review from
garethgreenaway
and removed request for
a team
cmcmarrow
added
Phosphorus v3005.0
Ch3LL
suggested changes
Dec 13, 2021
|
bump @cmcmarrow did you see my review? |
garethgreenaway
changed the title
cmcmarrow
removed
the
Needs-Testcase
waynew
suggested changes
Feb 28, 2022
twangboy
previously approved these changes
Mar 1, 2022
|
Theres some test failures that need to be cleaned up |
|
@cmcmarrow are you able to come back to this PR and fix the tests? |
Ch3LL
previously approved these changes
Oct 10, 2022
|
@waynew can you re-review this please |
whytewolf
previously approved these changes
Oct 10, 2022
s0undt3ch
suggested changes
Oct 10, 2022
MKLeb
previously approved these changes
Oct 10, 2022
twangboy
previously approved these changes
Oct 10, 2022
garethgreenaway
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Avoids crash on cache corruption
What issues does this PR fix or reference?
Fixes: #60170
Previous Behavior
Hard crash
New Behavior
Error is logged at error level
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.