Corrected documentation and minion configuration setting for auto recover for Master IP changes #61577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmurphy18
requested review from
garethgreenaway
and removed request for
a team
Ch3LL
suggested changes
Feb 4, 2022
added 2 commits
February 4, 2022 11:17
dmurphy18
force-pushed
the
master_ip_change_bug_61482
branch
from
7aace6c to
be3fcc1
Compare
twangboy
approved these changes
Feb 4, 2022
waynew
approved these changes
Feb 4, 2022
Ch3LL
approved these changes
Feb 4, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Corrects the documentation in Minion Configuration file for auto recover minions if master changes IP address (DDNS)
What issues doehttps://github.com/saltstack/salt/issues/61482s this PR fix or reference?
Fixes:
Previous Behavior
No auto recovery would occur, due to recommended auto_safemode was incorrect (False)
New Behavior
auto recovery now occurs, with corrected auto_safemode setting (True)
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.