Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mac build scripts to use .pyenv #61779

Merged
merged 5 commits into from
May 24, 2022
Merged

Update mac build scripts to use .pyenv #61779

merged 5 commits into from
May 24, 2022

Conversation

twangboy
Copy link
Contributor

What does this PR do?

Fix failing MacOS builds using pyenv to build python environment.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@twangboy twangboy requested a review from a team as a code owner March 11, 2022 01:22
@twangboy twangboy requested review from waynew and removed request for a team March 11, 2022 01:22
@twangboy twangboy force-pushed the build_patch_master branch from fe134a5 to 328976e Compare March 11, 2022 18:52
waynew
waynew previously approved these changes Mar 11, 2022
View reviewed changes
@twangboy twangboy added this to the Phosphorus v3005.0 milestone Mar 29, 2022
@twangboy twangboy added the Phosphorus v3005.0 Release code name and version label Mar 29, 2022
Ch3LL
Ch3LL suggested changes Apr 5, 2022
View reviewed changes
@twangboy twangboy force-pushed the build_patch_master branch 3 times, most recently from c4b0a51 to 35e3980 Compare April 12, 2022 15:23
Ch3LL
Ch3LL suggested changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing the hard coded path to 3.7.12 in a couple of files in this PR. I think it would make sense to make that a variable so its easy to change versions.

@twangboy twangboy force-pushed the build_patch_master branch from 35e3980 to 63eaa79 Compare April 18, 2022 17:38
@Ch3LL
Copy link
Contributor

Ch3LL commented May 20, 2022

It looks like you force pushed, but I'm still seeing 3.7.12 hard coded.

@twangboy twangboy mentioned this pull request May 20, 2022
Closed
3 tasks
@twangboy twangboy force-pushed the build_patch_master branch from 63eaa79 to 8a6b577 Compare May 20, 2022 21:49
@twangboy twangboy force-pushed the build_patch_master branch from 51a8cf5 to cb01886 Compare May 21, 2022 01:05
@garethgreenaway garethgreenaway merged commit e36f751 into saltstack:master May 24, 2022
@MKLeb MKLeb mentioned this pull request Jun 13, 2022
Merged
@twangboy twangboy deleted the build_patch_master branch March 23, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s0undt3ch s0undt3ch s0undt3ch approved these changes

@garethgreenaway garethgreenaway garethgreenaway approved these changes

@Ch3LL Ch3LL Ch3LL approved these changes

@waynew waynew waynew left review comments

Assignees
No one assigned
Labels
Phosphorus v3005.0 Release code name and version
Projects
None yet
Milestone
Phosphorus v3005.0
Development

Successfully merging this pull request may close these issues.
5 participants
@twangboy @Ch3LL @waynew @s0undt3ch @garethgreenaway