Update docs remove dry_run in docstring of file.blockreplace state. #61916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@barbaricyawps here is my attempt at this doc update. |
MKLeb
reviewed
Apr 6, 2022
doc/man/salt.7
Outdated
Comment on lines
403020
to
403023
| .B dry_run | ||
| If \fBTrue\fP, do not make any edits to the file and simply return the | ||
| changes that \fIwould\fP be made. | ||
| .TP |
There was a problem hiding this comment.
We don't need to update the man pages, that is done during the release process. Would you mind reverting these changes?
There was a problem hiding this comment.
Thanks for the feedback, it's my first time doing a doc update and I just did a git grep to catch possible changes needed. I've reverted the man page change.
|
@MKLeb is anything else needed for this review? |
MKLeb
approved these changes
Apr 13, 2022
|
@ericham Nope, sorry. I'll see when we can get this merged. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update docs remove dry_run in docstring of file.blockreplace state.
What issues does this PR fix or reference?
Fixes: #60227
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.