Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Napalm proxy better error handling #62434

Merged

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Aug 5, 2022

What does this PR do?

Napalm proxy better error handling

What issues does this PR fix or reference?

Fixes: #62435

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from a team as a code owner August 5, 2022 22:08
@garethgreenaway garethgreenaway requested review from whytewolf and removed request for a team August 5, 2022 22:08
Copy link
Collaborator

@s0undt3ch s0undt3ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And since we're at it, and this is the master branch, how about we bump the napalm requirement version to latest?

salt/proxy/napalm.py Outdated Show resolved Hide resolved
tests/pytests/unit/proxy/test_napalm.py Outdated Show resolved Hide resolved
tests/pytests/unit/proxy/test_napalm.py Outdated Show resolved Hide resolved
@s0undt3ch
Copy link
Collaborator

Can we also upgrade the napalm dependency?
... Since we're at it...

salt/proxy/napalm.py Outdated Show resolved Hide resolved
salt/proxy/napalm.py Outdated Show resolved Hide resolved
@Ch3LL Ch3LL added merge-conflict PR has a merge conflict Sulfur v3006.0 release code name and version labels Oct 4, 2022
@Ch3LL
Copy link
Contributor

Ch3LL commented Oct 6, 2022

@garethgreenaway can you resolve the merge conflict

@garethgreenaway garethgreenaway force-pushed the napalm_proxy_better_error_handling branch from a80044e to 8b531de Compare October 8, 2022 18:19
@garethgreenaway garethgreenaway removed the merge-conflict PR has a merge conflict label Oct 11, 2022
@Ch3LL Ch3LL merged commit fe8f325 into saltstack:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sulfur v3006.0 release code name and version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] napalm proxy returns True when connections fail
5 participants