Add ifelse function as found in CFEngine #62509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
re-run pr-ubuntu-2004-amd64-py3-m2crypto-pytest |
|
I'm confused. is this only meant to be a Jinja function? if so it doesn't belong in modules.match. but if it is meant to be more than just a jinja function the wording on the docstring needs to be updated to show how it can be useful outside ofjinja as well. |
|
I'm not sure what needs to be updated in the docstring... It has a command line example. Can you provide some direction on what you think should be updated? |
nicholasmhughes
changed the title
|
You are correct, not sure what i was thinking about. Yes you are correct the module does have an example for inline use. |
whytewolf
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See issue for details.
What issues does this PR fix or reference?
Fixes: #62508
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.