added additional mariadb grant types #62545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds missing mariadb grant types from long term open issue
What issues does this PR fix or reference?
Fixes: #58297
This does not solve a re-mapping logic fix that has been in an open pr (#59280) but solves the main issue with not being able to set grant types on newer mariadb servers.
long term the additional changes in 59280 is needed so that if someone attempts to use "replication client" grant it will remap to "binlog monitor" and not return a salt error for unexpected state.
however as long as the user requests the correct grant in states against the correct version this pr will work just fine.
Previous Behavior
salt would return an error as the expected grant would not exist
New Behavior
allows newer mariadb grant types
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.