Feature/version dot zero #62742
Merged
Feature/version dot zero #62742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ch3LL
approved these changes
Sep 27, 2022
twangboy
approved these changes
Sep 28, 2022
s0undt3ch
approved these changes
Sep 28, 2022
| @@ -54,6 +54,10 @@ | |||
| (3000, 2, "nb", 20201214010203, 0, "1e7bc8f"), | |||
| "3000.2nb20201214010203", | |||
| ), | |||
| ("v3006.0", (3006, 0, "", 0, 0, None), "3006.0"), | |||
There was a problem hiding this comment.
Suggested change
| ("v3006.0", (3006, 0, "", 0, 0, None), "3006.0"), | |
| ("v3006.0", (3006, 0, "", 0, 0, None), "3006"), | |
| ("v3006.0", (3006, 0, "", 0, 0, None), "3006.0"), |
Maybe also try to see if it handles bad tags?
dmurphy18
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the
.0back to our versioning scheme. Now, our newer major releases have minor data, but that data is 0.NOTE: In order to have this change happen, we now need to tag future releases like 3006 as 3006.0, since most of the logic is done with
git describeWhat issues does this PR fix or reference?
Fixes: #60772
Previous Behavior
Our major releases did not have a
.0appendned to their version.New Behavior
Our next major release, for example, should have version 3006.0
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes