Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning to syndic about eauth/publisher_acl #62746

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

waynew
Copy link
Contributor

@waynew waynew commented Sep 23, 2022

What does this PR do?

Add docs, making it explicit that eauth/publisher_acl is not expected to work with Syndic (yet), also links to #62618, which will be used to track the actual fix.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

  • Docs

Commits signed with GPG?

Yes

@waynew waynew requested a review from a team as a code owner September 23, 2022 22:25
@waynew waynew requested review from twangboy and removed request for a team September 23, 2022 22:25
@waynew
Copy link
Contributor Author

waynew commented Sep 23, 2022

Didn't get docs to build/preview locally - will need to double check Jenkins output to make sure that the actual link looks correct

Ch3LL
Ch3LL previously approved these changes Sep 26, 2022
@waynew
Copy link
Contributor Author

waynew commented Sep 26, 2022

@Ch3LL downloaded the built HTML docs from https://github.com/saltstack/salt/actions/runs/3115997991 and checked out topology/syndic.html and verified that the warning appears as expected, as well as both of the links work correctly 👍

@Ch3LL Ch3LL merged commit a0d3c44 into saltstack:freeze Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants