-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Slack engine to use slack_bolt #62957
Updating Slack engine to use slack_bolt #62957
Conversation
…from Slack before they are handled.
126ed08
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks to be a breaking change for users using the slackclient as it will require them to install a dependency and update their configs to include app_token
and bot_token
. Is there a reason we are not including the old slackclient functionality and putting it on a deprecation path?
I think @Ch3LL is right here. The rtm API still works with slack and I just set up a "legacy bot user" which is able to successfully send messages from our v3004 install. It'd be nice to have a deprecation path for this so that our integration doesn't stop working immediately when we upgrade to v3006 with no way to smoothly transition. It's also important to note that while Slack does recommend moving away from the rtm API, they have not deprecated it. https://slack.dev/node-slack-sdk/rtm-api
Once you create a legacy scoped app, you just need to add the Bots feature, and when the app is installed you'll be given a bot token, which is what I put in the as the api key in our salt config. On the permissions page for the app, there will be a warning recommending to update to granular scopes: However, as the warning at the top of the scope update page says, the app will no longer be able to use the rtm API if you change to granular scopes: |
What does this PR do?
Updating Slack engine to use slack_bolt
What issues does this PR fix or reference?
Fixes: #57842
Fixes: #62812
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.