Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pkgrepo.managed PPA handling for newer Ubuntu versions #63157

Closed
wants to merge 1 commit into from

Conversation

theblazehen
Copy link

@theblazehen theblazehen commented Nov 30, 2022

What does this PR do?

Fixed PPA handling in newer Ubuntu versions with patch provided in #59065 (comment)

What issues does this PR fix or reference?

Fixes: #59065

Previous Behavior

It would fail to manage PPA repos

New Behavior

It now handles PPA repos

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@theblazehen theblazehen requested a review from a team as a code owner November 30, 2022 19:18
@theblazehen theblazehen requested review from dwoz and removed request for a team November 30, 2022 19:18
@welcome
Copy link

welcome bot commented Nov 30, 2022

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@whytewolf
Copy link
Collaborator

so, I'm wondering about onedir here. as onedir will not have access to softwareproperties. your code doesn't touch anything that doesn't have softwareproperties. so while this will work in a pip installed environment. if there anything that needs to be changed in the other side of the if statmnts that check if HAS_SOFTWAREPROPERTIES

@chielboogaard
Copy link

Would love to get the PR merged because we are running in to the issue and cannot deploy ppa packages.

@whytewolf whytewolf added Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases needs-changelog-file labels Jan 17, 2023
@whytewolf
Copy link
Collaborator

Would love to get the PR merged because we are running in to the issue and cannot deploy ppa packages.

with the question i brought up in is unknown if this will fix the issue with onedir based installs. the user also needs to add tests and a changelog. so this is very unlikely to get merged in it's current state.

@dwoz
Copy link
Contributor

dwoz commented Dec 11, 2023

Closing this due to inactivity. Anyone should feel free to re-open it if they want to see it through to the end in one release cycle.

@dwoz dwoz closed this Dec 11, 2023
@dwoz dwoz added help-wanted Community help is needed to resolve this Abandoned labels Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Abandoned help-wanted Community help is needed to resolve this needs-changelog-file Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] pkgrepo.managed fails to configure ppa on Ubuntu 20.10
4 participants