-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/syndic/62618 - external auth #63257
Closed
Closed
Commits on Dec 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 779ca84 - Browse repository at this point
Copy the full SHA 779ca84View commit details -
Configuration menu - View commit details
-
Copy full SHA for e231a5a - Browse repository at this point
Copy the full SHA e231a5aView commit details -
Convert syndics to use older AsyncReqChannel
There *may* be a better way to get results from syndics to the Master of Masters, but this at least works. Fixes saltstack#62933
Configuration menu - View commit details
-
Copy full SHA for 16a44a5 - Browse repository at this point
Copy the full SHA 16a44a5View commit details -
refactor publish, extract publisher_acl
Aiming to simplify publish where possible, to make it easier to follow.
Configuration menu - View commit details
-
Copy full SHA for f1b37d8 - Browse repository at this point
Copy the full SHA f1b37d8View commit details -
This is a complete restructure of how Master-of-Masters and Syndics communicate when publishing a job. In the past, if we were a MoM, the undocumented but desired approach was that the MoM would not have any minions attached to it. Because when a Salt Master was a MoM it would simply publish the job 100% of the time unless the ACL denied the command. But this was not based on whether or not there were minions that could be targeted. In fact, when no valid minions were found then the job would be published, it was only when there were *invalid* minions found that things would be rejected. This new approach is for the MoM to make a request of the syndics to return a list of minions that match both the allowed ACL targets as well as the requested targets. On the MoM if the user has requested more minions than they have access to then we will fail on authorization. There are a few known issues with the existing architecture: 1. It's possible (though undocumented as to what the behavior should be) for multiple syndics to have different minions with the same ID. 2. Based on timing, and without a complete rearchitecture of Syndics (planned for 2023), if a syndic comes online *after* targeting data is returned and *before* the job is published it's possible that a user may be able to publish jobs to minions they should not have access to. 3. It's undocumented how things should work if a Syndic is a MoM. But now - when using external auth, or publisher_acl, the only time a job should be published is when the provided user actually has the correct ACL to publish the jobs.
Configuration menu - View commit details
-
Copy full SHA for 0b259a8 - Browse repository at this point
Copy the full SHA 0b259a8View commit details -
Yeah, maybe Syndics have been around for a while but a lot of their behavior is not well-defined.
Configuration menu - View commit details
-
Copy full SHA for 5b7729f - Browse repository at this point
Copy the full SHA 5b7729fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d8e8c3 - Browse repository at this point
Copy the full SHA 2d8e8c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4e5055 - Browse repository at this point
Copy the full SHA c4e5055View commit details -
Configuration menu - View commit details
-
Copy full SHA for d79fbab - Browse repository at this point
Copy the full SHA d79fbabView commit details -
Do our tests care we cannot connect to docker in the environment? We do not. If docker can't get the client to connect it's OK, we'll just skip the tests. At least *one* of our platforms should be running these tests, which is enough.
Configuration menu - View commit details
-
Copy full SHA for 0fe8db6 - Browse repository at this point
Copy the full SHA 0fe8db6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d40ae8d - Browse repository at this point
Copy the full SHA d40ae8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed5389a - Browse repository at this point
Copy the full SHA ed5389aView commit details -
No need to fail when we can't clean up. VMs *should* be going away, and if you're running locally you can clean up yourself 👍
Configuration menu - View commit details
-
Copy full SHA for 39b079c - Browse repository at this point
Copy the full SHA 39b079cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98a3d45 - Browse repository at this point
Copy the full SHA 98a3d45View commit details
Commits on Dec 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6e36e03 - Browse repository at this point
Copy the full SHA 6e36e03View commit details
Commits on Dec 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1ce5576 - Browse repository at this point
Copy the full SHA 1ce5576View commit details
Commits on Dec 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d843ecf - Browse repository at this point
Copy the full SHA d843ecfView commit details
Commits on Dec 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 44cb6b2 - Browse repository at this point
Copy the full SHA 44cb6b2View commit details
Commits on Jan 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 92e490b - Browse repository at this point
Copy the full SHA 92e490bView commit details
Commits on Jan 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0336010 - Browse repository at this point
Copy the full SHA 0336010View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.