Add vault database secret engine modules
#63314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit represents a fundamental rewrite in how Salt interacts with Vault. The master should still be compatible with minions running the old code. There should be no breaking changes to public interfaces and the old configuration format should still apply. Core: - Issue AppRoles to minions - Manage entities with templatable metadata for minions - Use inbuilt Salt cache - Separate config cache from token cache - Cache: introduce connection-scope vs global scope Utility module: - Support being imported (__utils__ deprecation) - Raise exceptions on queries to simplify response handling - Add classes to wrap complexity, especially regarding KV v2 - Lay some groundwork for renewing tokens Execution module: - Add patch_secret - Add version support to delete_secret - Allow returning listed keys only in list_secret - Add policy_[fetch/write/delete] and policies_list - Add query for arbitrary API queries State module: - Make use of execution module - Change output format Docs: - Update for new configuration format - Correct examples - Add configuration examples - Add required policies
* Always use session cache as well * Also flush session cache when requested * Make KV metadata caching behavior configurable * Update tests to account for changes from prev commit
There is no simple way to ensure they are kept.
* assert what you get against what you expect * drop empty parentheses after wrapper * use `is` to compare against strictly boolean vars
* during pillar rendering, they were always reset by the master (for AppRoles) * overrides were only respected for some settings (AppRoles) * old config syntax was using the old syntax internally (tech debt)
after renaming the token cache key
3 tasks
|
Closing this since the code this depends on has been moved to https://github.com/salt-extensions/saltext-vault, will submit this there later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds modules that allow to manage the Vault
databasesecret engine.This is based on the improved Vault integration found in #62684, thus this will stay a draft until that PR is merged. I wanted to put this out anyways for visibility and to get possible input.
Note that the tests only verify the
mysqldatabase plugin. I cannot test all possible plugins, so there might be some issues left.What issues does this PR fix or reference?
TODO
Merge requirements satisfied?
Commits signed with GPG?
Yes