Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3006.x] Fix cmd.run doesn't output changes in test mode #64164

Merged
merged 2 commits into from
Apr 26, 2023
Merged

[3006.x] Fix cmd.run doesn't output changes in test mode #64164

merged 2 commits into from
Apr 26, 2023

Conversation

cmcmarrow
Copy link
Contributor

What does this PR do?

See issue for details.

What issues does this PR fix or reference?

Fixes: #64150

Previous Behavior

          ID: echo hello
    Function: cmd.run
      Result: None
     Comment: Command "echo hello" would have been executed
     Started: 18:23:03.961085
    Duration: 0.481 ms
     Changes:

New Behavior

          ID: echo hello
    Function: cmd.run
      Result: None
     Comment: Command "echo hello" would have been executed
     Started: 18:31:14.193750
    Duration: 0.52 ms
     Changes:   
              ----------
              cmd:
                  echo hello

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@cmcmarrow cmcmarrow requested a review from a team as a code owner April 26, 2023 02:49
@cmcmarrow cmcmarrow requested review from dwoz and removed request for a team April 26, 2023 02:49
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Fix cmd.run doesn't output changes in test mode [master] Fix cmd.run doesn't output changes in test mode Apr 26, 2023
@cmcmarrow cmcmarrow changed the base branch from master to 3006.x April 26, 2023 02:49
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [master] Fix cmd.run doesn't output changes in test mode [3006.x] Fix cmd.run doesn't output changes in test mode Apr 26, 2023
@cmcmarrow
Copy link
Contributor Author

cherry pick #64151, thanks @nicholasmhughes

@cmcmarrow cmcmarrow temporarily deployed to ci April 26, 2023 03:09 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci April 26, 2023 03:09 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci April 26, 2023 03:09 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci April 26, 2023 08:00 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci April 26, 2023 08:00 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci April 26, 2023 08:00 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci April 26, 2023 08:49 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci April 26, 2023 08:49 — with GitHub Actions Inactive
@cmcmarrow cmcmarrow temporarily deployed to ci April 26, 2023 08:49 — with GitHub Actions Inactive
@twangboy twangboy merged commit 47a5469 into saltstack:3006.x Apr 26, 2023
@s0undt3ch s0undt3ch deleted the pick_nichol_cmd_fix branch April 26, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twangboy twangboy twangboy approved these changes

@s0undt3ch s0undt3ch s0undt3ch approved these changes

@dwoz dwoz Awaiting requested review from dwoz dwoz was automatically assigned from saltstack/team-core

Assignees
No one assigned
Labels
Sulfur v3006.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] cmd.run doesn't output changes in test mode
4 participants
@cmcmarrow @s0undt3ch @twangboy @nicholasmhughes