Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Fix 2 pkgrepo.absent bugs for apt-based distros #64287

Closed
wants to merge 7 commits into from
Closed

[master] Fix 2 pkgrepo.absent bugs for apt-based distros #64287

wants to merge 7 commits into from

Conversation

terminalmage
Copy link
Contributor

@terminalmage terminalmage commented May 16, 2023 •
edited
Loading

What does this PR do?

Resolves 2 pkgrepo.absent bugs

What issues does this PR fix or reference?

Fixes: #64286

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

@terminalmage terminalmage requested a review from a team as a code owner May 16, 2023 14:36
@terminalmage terminalmage requested review from twangboy and removed request for a team May 16, 2023 14:36
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Fix 2 pkgrepo.absent bugs for apt-based distros [master] Fix 2 pkgrepo.absent bugs for apt-based distros May 16, 2023
@terminalmage terminalmage temporarily deployed to ci May 16, 2023 14:53 — with GitHub Actions Inactive
@terminalmage terminalmage temporarily deployed to ci May 16, 2023 14:53 — with GitHub Actions Inactive
@terminalmage terminalmage temporarily deployed to ci May 16, 2023 14:53 — with GitHub Actions Inactive
@terminalmage terminalmage temporarily deployed to ci May 16, 2023 16:14 — with GitHub Actions Inactive
@terminalmage terminalmage temporarily deployed to ci May 16, 2023 16:14 — with GitHub Actions Inactive
@terminalmage terminalmage temporarily deployed to ci May 16, 2023 16:14 — with GitHub Actions Inactive
@terminalmage terminalmage temporarily deployed to ci May 16, 2023 17:12 — with GitHub Actions Inactive
@terminalmage terminalmage temporarily deployed to ci May 16, 2023 17:12 — with GitHub Actions Inactive
@terminalmage terminalmage temporarily deployed to ci May 16, 2023 17:12 — with GitHub Actions Inactive
Ch3LL
Ch3LL suggested changes May 17, 2023
View reviewed changes
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also require test coverage. Thanks for this :)

changelog/64286.fixed.md Outdated Show resolved Hide resolved
twangboy
twangboy previously approved these changes May 22, 2023
View reviewed changes
@terminalmage terminalmage force-pushed the pkgrepo-absent-bugs branch from 3616682 to c21d64b Compare May 24, 2023 05:00
@terminalmage
Copy link
Contributor Author

@Ch3LL It turned out that my fix had downstream effects that caused problems with pkgrepo.managed, so I had to revise the fix. In the process I exposed one of the private functions from aptpkg.py so it could be invoked from within the pkgrepo state module.

Going to bed now, will check on tests in the morning 🙂

@terminalmage terminalmage requested a review from Ch3LL May 24, 2023 05:09
@terminalmage terminalmage temporarily deployed to ci May 24, 2023 06:34 — with GitHub Actions Inactive
@terminalmage terminalmage temporarily deployed to ci May 24, 2023 06:34 — with GitHub Actions Inactive
@terminalmage terminalmage temporarily deployed to ci May 24, 2023 06:34 — with GitHub Actions Inactive
@terminalmage terminalmage temporarily deployed to ci May 24, 2023 13:51 — with GitHub Actions Inactive
@terminalmage terminalmage temporarily deployed to ci May 24, 2023 13:51 — with GitHub Actions Inactive
@terminalmage terminalmage temporarily deployed to ci May 24, 2023 13:51 — with GitHub Actions Inactive
@terminalmage
Copy link
Contributor Author

terminalmage commented May 24, 2023 •
edited
Loading

The pkgrepo tests are passing. This DEB build test is failing though, and there appear to be no details there so I don't know what caused it.

It also looks like some CI runners might be down because several of the docs tests are stalled waiting for a free runner.

@s0undt3ch s0undt3ch added the backport:3006.x Backport PR to 3006.x branch label May 26, 2023
@terminalmage terminalmage temporarily deployed to ci May 26, 2023 06:34 — with GitHub Actions Inactive
@terminalmage terminalmage temporarily deployed to ci June 29, 2023 16:50 — with GitHub Actions Inactive
@terminalmage terminalmage temporarily deployed to ci June 29, 2023 16:50 — with GitHub Actions Inactive
@terminalmage terminalmage temporarily deployed to ci June 29, 2023 16:50 — with GitHub Actions Inactive
@terminalmage terminalmage temporarily deployed to ci June 29, 2023 17:09 — with GitHub Actions Inactive
@terminalmage terminalmage temporarily deployed to ci June 29, 2023 17:10 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 7, 2023 20:48 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 7, 2023 20:48 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 7, 2023 21:04 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 7, 2023 21:08 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 7, 2023 21:24 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 7, 2023 21:25 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 7, 2023 22:48 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 7, 2023 22:48 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 7, 2023 22:48 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 7, 2023 22:48 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 7, 2023 22:48 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 7, 2023 22:48 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 7, 2023 23:18 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 7, 2023 23:18 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 7, 2023 23:18 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 7, 2023 23:19 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 7, 2023 23:19 — with GitHub Actions Inactive
@Ch3LL Ch3LL temporarily deployed to ci August 7, 2023 23:19 — with GitHub Actions Inactive
@Ch3LL Ch3LL mentioned this pull request Aug 15, 2023
Merged
@Ch3LL
Copy link
Contributor

Ch3LL commented Aug 17, 2023

@terminalmage you okay closing this now that #64995 is merged in. This will be merged forward into master.

@terminalmage
Copy link
Contributor Author

Sure, thanks!

@terminalmage terminalmage deleted the pkgrepo-absent-bugs branch February 13, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twangboy twangboy twangboy left review comments

@Ch3LL Ch3LL Ch3LL left review comments

@s0undt3ch s0undt3ch s0undt3ch left review comments

@garethgreenaway garethgreenaway Awaiting requested review from garethgreenaway

Assignees
No one assigned
Labels
backport:3006.x Backport PR to 3006.x branch Chlorine v3007.0 has-failing-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] [3006.1] pkgrepo.absent fails in 2 specific cases for apt-based distros
4 participants
@terminalmage @Ch3LL @s0undt3ch @twangboy