[master] APPX: Fix issue when there are duplicate packages #64535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
stavros-k
approved these changes
Jun 25, 2023
There was a problem hiding this comment.
Hey, Fired up couple of VMs I had for testing, and none of them seem to have any duplicates now -.-
I've tried a snapshot restore on one of them, I can see there are duplicates there when its booted, but by the time I manage to copy the patched files, the duplicate is already gone.
But either way, PR is looking good to me. it looks like it will catch this duplicates
Ch3LL
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue where multiple packages match the query for packages to be removed. Some packages can be in a state where they're being updated. In that scenario, two packages with different versions may match the query. One of the packages will be missing the uninstall information as well.
What issues does this PR fix or reference?
Fixes: #64450
Previous Behavior
Stacktrace on duplicate names
Stacktrace when the package is missing AppxManifest.xml
New Behavior
Don't stack trace on multiple matching packages
Log the error and continue if the package is missing the AppxManifest.xml
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes