Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x][WIP] 3006 debian12 support #64544

Closed
wants to merge 3 commits into from

Conversation

lastmikoi
Copy link
Contributor

What does this PR do?

This work in progress PR tries to add package building for Debian 12, as, while official support for Debian 12 won't happen until 3007, some of us would still like to use onedir Salt packages for that target.

What issues does this PR fix or reference?

References: #64223 (doesn't fix)

Previous Behavior

No Salt packages delivered for Debian 12

New Behavior

Salt packages delivered for Debian 12

Merge requirements satisfied?

Work in progress PR that I need to submit in order to make the CI run (I don't have access to the selfhosted github action CI nodes)

Commits signed with GPG?

Yes

@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [WIP] 3006 debian12 support [3006.x][WIP] 3006 debian12 support Jun 26, 2023
@lastmikoi lastmikoi temporarily deployed to ci June 26, 2023 08:58 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 26, 2023 08:58 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 26, 2023 08:58 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 26, 2023 08:58 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 26, 2023 09:15 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 26, 2023 09:16 — with GitHub Actions Inactive
@lastmikoi
Copy link
Contributor Author

Pinging @s0undt3ch as they seem to be codeowner of cicd/golden-images.json: Hi ! It seems that the CI Image for Debian 12 is missing from what appears to be a selfhosted set of CI runners running on AWS (I'm completely unfamiliar with Salt's CI setup, so I may be wildly mistaken). Is there anything I can do on my end to help out with getting that image added and my pipeline unblocked ?

@lastmikoi lastmikoi force-pushed the 3006-debian12-support branch from 945bc74 to ca7a088 Compare June 26, 2023 11:14
@lastmikoi lastmikoi temporarily deployed to ci June 26, 2023 11:35 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 26, 2023 11:35 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 26, 2023 11:35 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 26, 2023 11:36 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 26, 2023 11:50 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 26, 2023 11:52 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 26, 2023 12:46 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 26, 2023 12:46 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 26, 2023 12:46 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 26, 2023 12:46 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 26, 2023 12:47 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 26, 2023 12:47 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 26, 2023 13:05 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 26, 2023 13:05 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 26, 2023 13:05 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 26, 2023 13:05 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 26, 2023 13:06 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 26, 2023 13:06 — with GitHub Actions Inactive
@lastmikoi
Copy link
Contributor Author

Looks like it's been taken care of yesterday already ✨ saltstack/salt-ci-images#1811 (comment) I've updated my PR accordingly.

@lastmikoi lastmikoi force-pushed the 3006-debian12-support branch from d94b755 to 362e71a Compare June 27, 2023 12:57
@lastmikoi lastmikoi temporarily deployed to ci June 27, 2023 14:19 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 27, 2023 14:19 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 27, 2023 14:36 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 27, 2023 14:36 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 27, 2023 15:34 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 27, 2023 15:36 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 27, 2023 17:47 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 27, 2023 17:47 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 27, 2023 17:47 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 27, 2023 17:47 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 27, 2023 17:47 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 27, 2023 17:47 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 27, 2023 20:29 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 27, 2023 20:29 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 27, 2023 20:29 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 27, 2023 20:29 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 27, 2023 20:30 — with GitHub Actions Inactive
@lastmikoi lastmikoi temporarily deployed to ci June 27, 2023 20:30 — with GitHub Actions Inactive
@s0undt3ch
Copy link
Collaborator

Pinging @s0undt3ch as they seem to be codeowner of cicd/golden-images.json: Hi ! It seems that the CI Image for Debian 12 is missing from what appears to be a selfhosted set of CI runners running on AWS (I'm completely unfamiliar with Salt's CI setup, so I may be wildly mistaken). Is there anything I can do on my end to help out with getting that image added and my pipeline unblocked ?

saltstack/salt-ci-images#1811

@@ -15,6 +15,8 @@
("debian-10", "Debian 10", "x86_64", "package"),
("debian-11", "Debian 11", "x86_64", "package"),
("debian-11-arm64", "Debian 11 Arm64", "aarch64", "package"),
("debian-12", "Debian 12", "x86_64", "package"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have plans to add Debian 12 to our CI for the 3006.x branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aye, that's what I saw from the documentation that new OS support for LTS releases won't happen, but we're in a special predicament here, there's no Salt package for Debian12 provided by the OS, and there's no Salt package for Debian12 provided by saltproject. I can see that progress is being made for 3007.x, but I'm in the middle of an Ansible VS Saltstack evaluation pass at my dayjob and I'd love to be able to just use 3006.x "as-is" on a Debian12 environment, without any specific OS support.

So, how do I get Debian12 packages ? The whole process being automated and, frankly, quite difficult to reproduce locally, I figured that using the existing CI was the lowest hanging fruit, but if adding CI for debian12 is too much of a burden on 3006.x maintainers, I'll gladly take an alternative. I just want a few .deb files.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried the Debian 11 Debs?

@@ -991,6 +991,8 @@ __derive_debian_numeric_version() {
NUMERIC_VERSION=$(__parse_version_string "10.0")
elif [ "$INPUT_VERSION" = "bullseye/sid" ]; then
NUMERIC_VERSION=$(__parse_version_string "11.0")
elif [ "$INPUT_VERSION" = "bookworm/sid" ]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes must be done against the salt-bootstrap repository, not salt.

@ScriptAutomate
Copy link
Contributor

This PR is being superseded by:

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants