[3006.x] Allow for semange fcontext -l having trailing whitespace in selinux.fcontext_get_policy #64950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
|
This PR supersedes PR #63337 |
3 tasks
garethgreenaway
approved these changes
Aug 10, 2023
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes any trailing whitespace returned from
semanage fcontext -lon platforms supporting selinux.This was leading to erroneous returns when checked if a specific file context exists.
What issues does this PR fix or reference?
Fixes: #63336
Previous Behavior
If there were trailing whitespaces in the output of
semanage fcontext -l, the functionselinux.fcontext_get_policywould return no result even though there is one.New Behavior
Now the function
selinux.fcontext_get_policywill return the result even if there is a trailing whitespace.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.