[3006.x] Updated semanage fcontext to use --modify if context already exists when adding context #65003
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If a semanage fcontext already exists for a file, then the command
semanage fcontext --modify
is used rather thansemanage fcontext --add
What issues does this PR fix or reference?
Fixes:#64625
Previous Behavior
If the file already had a fcontext, a ValueError would be thrown, similar to the following
New Behavior
The code checks to see if If the file already has a fcontext, and uses
--modify
rather than--add
which will throw a ValueError if used in this case.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.