Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Add wildcard removal for aptpkg #65221

Merged

Conversation

nicholasmhughes
Copy link
Collaborator

What does this PR do?

See issue for details

What issues does this PR fix or reference?

Fixes: #65220

Previous Behavior

Wildcards could not be used for apt package removal

New Behavior

Now they can

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@nicholasmhughes nicholasmhughes requested a review from a team as a code owner September 18, 2023 15:53
@nicholasmhughes nicholasmhughes requested review from whytewolf and removed request for a team September 18, 2023 15:53
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add some functional tests that test the aptpkg and yumpkg code using wildcards to ensure that is also functional?

@nicholasmhughes nicholasmhughes temporarily deployed to ci September 19, 2023 14:27 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci September 19, 2023 14:27 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci September 19, 2023 14:27 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci September 19, 2023 14:27 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci September 19, 2023 14:44 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci September 19, 2023 14:49 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci September 19, 2023 19:38 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci September 19, 2023 19:38 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci September 19, 2023 19:38 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci September 19, 2023 19:38 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci September 19, 2023 19:38 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci September 19, 2023 19:38 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci September 19, 2023 20:34 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci September 19, 2023 20:34 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci September 19, 2023 20:34 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci September 19, 2023 20:34 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci September 19, 2023 21:22 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci September 19, 2023 21:22 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci September 19, 2023 21:22 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci November 2, 2023 23:04 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci November 2, 2023 23:04 — with GitHub Actions Inactive
@nicholasmhughes nicholasmhughes temporarily deployed to ci November 2, 2023 23:04 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway merged commit 040ae9e into saltstack:master Nov 15, 2023
416 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] add wildcard removal for aptpkg
4 participants