[3006.x] Fix issue with refresh_db on Windows #66184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
When a new package definition file was added to the repo you had to run refresh_db twice to get it to show up in the package databse. This clears the cache before refreshing the database to force changes.
s0undt3ch
approved these changes
Mar 11, 2024
|
|
||
|
|
||
| @pytest.fixture(scope="module") | ||
| def pkg_def_contents(state_tree): |
There was a problem hiding this comment.
Suggested change
| def pkg_def_contents(state_tree): | |
| def pkg_def_contents(): |
Not using the fixture
There was a problem hiding this comment.
Can be fixed at another time, it's not a real problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a new package definition file was added to the repo you had to run refresh_db twice to get it to show up in the package database. This clears the cache before refreshing the database to force changes.
What issues does this PR fix or reference?
Fixes: #63848
New Behavior
pkg.refresh_dbpicks up new package definition files on the first runMerge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes