[3006.x] file.managed correctly handles file path with '#' #66302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
s0undt3ch
approved these changes
Apr 8, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a bug in the file.managed state where file paths containing a "#" character are not handled correctly.
What issues does this PR fix or reference?
Fixes: 63060
Previous Behavior
The file.managed state fails to manage files correctly on subsequent runs if the file path contains a "#" character. The file is created correctly on the first run, but any subsequent run fails to manage the file. Salt attempts to diff on the incorrect file path, truncating the path at the "#" character.
New Behavior
The file.managed state now correctly handles file paths containing a "#" character. Files are managed correctly on all runs, and the correct file path is used for diffing.
Merge requirements satisfied?
Commits signed with GPG?
Yes