-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3007.x] Fix #66194: Exchange HTTPClient by AsyncHTTPClient in salt.utils.http #66330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
Fix #66194: Exchange HTTPClient by AsyncHTTPClient in salt.utils.http
[master] Fix #66194: Exchange HTTPClient by AsyncHTTPClient in salt.utils.http
Apr 9, 2024
Hey @krombel , since this effects 3007, would you mind rebasing this against the 3007.x branch? |
salt-project-bot-prod-environment
bot
changed the title
[master] Fix #66194: Exchange HTTPClient by AsyncHTTPClient in salt.utils.http
[3007.x] Fix #66194: Exchange HTTPClient by AsyncHTTPClient in salt.utils.http
Apr 19, 2024
@twangboy done |
@krombel Would you know how to write a test for this? |
I attempted this patch but got this error:
|
twangboy
approved these changes
Jun 12, 2024
Congratulations on your first PR being merged! 🎉 |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It replaces HTTPClient by AsyncHTTPClient
What issues does this PR fix or reference?
Fixes #66194
Background
tornadoweb/tornado#2325 (comment)
==> might be caused by #64304
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes