[3007.x] Make file.symlink/_symlink_check() respect follow_symlinks #66981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
twangboy
requested changes
Oct 21, 2024
tomdoherty
force-pushed
the
tomdoherty-_symlink_check-follow_symlinks
branch
from
8ed8317
to
8865c2e
Compare
Done! |
tomdoherty
force-pushed
the
tomdoherty-_symlink_check-follow_symlinks
branch
2 times, most recently
from
4239d1b
to
1b17e3c
Compare
tomdoherty
force-pushed
the
tomdoherty-_symlink_check-follow_symlinks
branch
from
1b17e3c
to
eef04d9
Compare
twangboy
approved these changes
Oct 25, 2024
|
Our infra is broken right now... once we get it fixed, we'll have you rebase and let the tests run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See issue for details
What issues does this PR fix or reference?
Fixes: #66980
Previous Behavior
_symlink_check()always usesos.path.existsregardless offollow_symlinksNew Behavior
follow_symlinks=Falsecausesos.path.lexists()to be used.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.