Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node args sequence error #473

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

dlt1111
Copy link
Contributor

@dlt1111 dlt1111 commented Jul 20, 2024

The sequence of node args is incorrect, causing the script "nextron --electron-options="--inspect=9229"" to fail

@saltyshiomix saltyshiomix self-assigned this Jul 21, 2024
@saltyshiomix saltyshiomix added bug Something isn't working good first issue Good for newcomers labels Jul 21, 2024
@saltyshiomix
Copy link
Owner

@dlt1111

Sorry for inconvenience.

I think this is not the bug of nextron.ts, but nextron-dev.ts

mainProcess = execa(
'electron',
['.', `${rendererPort}`, `${electronOptions}`],
{
detached: true,
...execaOptions,
}
)

I will merge this PR once, and then radically modify the CLI options and logics!

@dlt1111
Copy link
Contributor Author

dlt1111 commented Jul 21, 2024

@dlt1111

Sorry for inconvenience.

I think this is not the bug of nextron.ts, but nextron-dev.ts

mainProcess = execa(
'electron',
['.', `${rendererPort}`, `${electronOptions}`],
{
detached: true,
...execaOptions,
}
)

I will merge this PR once, and then radically modify the CLI options and logics!

@saltyshiomix
Thanks for replying to me.
I don't think so. I console something at top of the nextron-dev.ts, but nothing to show. Before that , the terminal had display error like "bad option xxxx".

@saltyshiomix
Copy link
Owner

@dlt1111

Ok, I'll check it a bit more :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants