fix: avoid method call and just copy doc values reference

salvatore-campagna · Aug 31, 2023 · 1135bfe · 1135bfe
1 parent 3ec037f
commit 1135bfe
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...in/java/org/elasticsearch/search/aggregations/metrics/GlobalOrdCardinalityAggregator.java b/...in/java/org/elasticsearch/search/aggregations/metrics/GlobalOrdCardinalityAggregator.java
@@ -211,7 +211,7 @@ public LeafBucketCollector getLeafCollector(AggregationExecutionContext aggCtx,
                 if (maxOrd <= MAX_FIELD_CARDINALITY_FOR_DYNAMIC_PRUNING || numNonVisitedOrds <= MAX_TERMS_FOR_DYNAMIC_PRUNING) {
                     dynamicPruningAttempts++;
                     return new LeafBucketCollector() {
-                        final SortedSetDocValues docValues = valuesSource.globalOrdinalsValues(aggCtx.getLeafReaderContext());
+                        final SortedSetDocValues docValues = values;
 
                         final BitArray bits;
                         final CompetitiveIterator competitiveIterator;
@@ -268,7 +268,7 @@ public CompetitiveIterator competitiveIterator() {
 
         bruteForce++;
         return new LeafBucketCollector() {
-            final SortedSetDocValues docValues = valuesSource.globalOrdinalsValues(aggCtx.getLeafReaderContext());
+            final SortedSetDocValues docValues = values;
 
             @Override
             public void collect(int doc, long bucketOrd) throws IOException {