feat: remove logic in compile.ts to flatten references to expressions

[sam-goodwin]

Partial #374

• remove flattening logic from compile.ts

function foo() {
  $AWS.DynamoDB.GetItem(..)

  // before:
  CallExpr(ReferenceExpr(() => $AWS.DynamoDB.GetItem), ..)

  // now:
  CallExpr(PropAccessExpr(GetItem, PropAccessExpr(DynamoDB, ReferenceExpr(() => $AWS)))
}

• update interpreters to resolve FucntionlessAST to ReferenceExpr as we can no longer rely on that work being done during tsc.

[netlify]

✅ Deploy Preview for effortless-malabi-1c3e77 ready!

Name	Link
🔨 Latest commit	92ddb3d
🔍 Latest deploy log	https://app.netlify.com/sites/effortless-malabi-1c3e77/deploys/62ead6de04355e00091898e4
😎 Deploy Preview	https://deploy-preview-376--effortless-malabi-1c3e77.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[thantos]

This seems wrong? Default value can only be determined at runtime.

const { a = func } = b ? { a: func2 } : { a: undefined }

a is func if b is falsey (runtime) or func2 is undefined (maybe runtime)

[sam-goodwin]

We care calling resolve on the defaultValue which can return 0, 1 or many possible values. In your case, we would have logic for the ConditionExpr that returns [{a: func2}, {a: undefined}] which then distributes to [func2, undefined] which then unions with a = func to create [func, func2, undefined] as the set of all possible values that a can be.

[sam-goodwin]

Let's expand on this in #310 ?

[thantos]

what is pattern here?

[sam-goodwin]

bad name - it's one of the possible values that node.initializer can be

[thantos]

Is this implemented? I don't see any code that could return an array of more than 1

[sam-goodwin]

Not yet, no. I implemented only the cases I needed for the tests to pass - incremental progress. I added the comments as I was thinking it through.

[sam-goodwin]

We would need to update the interpreter logic to support this case so it didn't matter.