fix(step-functions): props are not correctly passed to step function #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for effortless-malabi-1c3e77 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sam-goodwin
changed the title
sam-goodwin
reviewed
Aug 25, 2022
Comment on lines
+1582
to
+1584
| isFunctionLike(args[0]) || isErr(args[0]) || typeof args[0] === "function" | ||
| ? {} | ||
| : (args[1] as StepFunctionProps); | ||
| : args[0]; |
Owner
There was a problem hiding this comment.
What case is this catching? When would this be a function?
Collaborator
Author
There was a problem hiding this comment.
the actual change was changing the index from 1 to 0, the function check narrows the types it comes in as without using as, it will actually be expressions, but the type on it is a function.
| ); | ||
|
|
||
| test( | ||
| "props", |
Signed-off-by: github-actions <github-actions@github.com>
sam-goodwin
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #441