Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base64 encoding for some image packets and update node-sass #41

Merged
merged 2 commits into from
May 30, 2018
Merged

Base64 encoding for some image packets and update node-sass #41

merged 2 commits into from
May 30, 2018

Conversation

kaganjd
Copy link
Collaborator

@kaganjd kaganjd commented May 29, 2018

  • Base64 encoding for gif, jpeg, and png only; base64 encoding for other formats like svg are not implemented

@kaganjd kaganjd requested a review from samatt May 29, 2018 18:04
@samatt
Copy link
Owner

samatt commented May 30, 2018

looks good!

@samatt samatt closed this May 30, 2018
@samatt samatt reopened this May 30, 2018
samatt
samatt reviewed May 30, 2018
View reviewed changes
Copy link
Owner

@samatt samatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@kaganjd kaganjd merged commit 4cc5b5c into samatt:master May 30, 2018
@kaganjd kaganjd mentioned this pull request Jun 5, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samatt samatt samatt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaganjd @samatt