Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print syntax errors with sourceName, lineNumber, and description #110

Merged
merged 1 commit into from
Oct 20, 2016
Merged

Print syntax errors with sourceName, lineNumber, and description #110

merged 1 commit into from
Oct 20, 2016

Conversation

hboylan
Copy link
Contributor

@hboylan hboylan commented Jan 5, 2016

As per issue #109

Couldn't figure out why Eclipse was formatting all lines of the file, but I've only added one import for JSError at line 40 and a small code block to print errors from 140-146.

Note that I've left the thrown exception at line 147 for simplicity.

Cheers!

@samaxes
Copy link
Owner

samaxes commented Oct 19, 2016

Hi @hboylan, have you tested your change?
I've merged this change locally but it still only prints the first error found.

@hboylan
Copy link
Contributor Author

hboylan commented Oct 19, 2016

Yea I did, but this was so long ago.

Don't forget to add the "verbose" flag to print them all.

@samaxes samaxes merged commit 113d622 into samaxes:master Oct 20, 2016
@samaxes samaxes self-assigned this Oct 20, 2016
@samaxes samaxes added this to the 1.7.5 milestone Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants