Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang base container version to 1.19 #28

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

anoopcs9
Copy link
Collaborator

No description provided.

@anoopcs9 anoopcs9 marked this pull request as ready for review July 31, 2023 09:37
@anoopcs9 anoopcs9 force-pushed the update-golang-base-1.19 branch 2 times, most recently from 9a0f2c4 to cffe1c1 Compare August 1, 2023 17:10
Copy link
Contributor

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phlogistonjohn
Copy link
Contributor

@anoopcs9 I notice that this is still open and you have marked it as a dependency of samba-in-kubernetes/samba-operator#313 . What's preventing merge?

@anoopcs9
Copy link
Collaborator Author

@anoopcs9 I notice that this is still open and you have marked it as a dependency of samba-in-kubernetes/samba-operator#313 . What's preventing merge?

Ah.. somehow this PR slipped my attention. Thanks for checking again.

@anoopcs9 anoopcs9 merged commit 4a7ecd9 into samba-in-kubernetes:main Aug 16, 2023
2 checks passed
@anoopcs9 anoopcs9 deleted the update-golang-base-1.19 branch August 16, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants