build-rpms: Use common target to build rpms #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With samba-in-kubernetes/samba-build#48 we combine version specific build targets for CentOS using a general makefile rule.
|
🎉 All dependencies have been resolved ! |
obnoxxx
requested changes
Jul 23, 2024
| make "test.rpms.${PLATFORM}${VERSION}" "refspec=${SAMBA_BRANCH}" | ||
| fi | ||
| make "rpms.${PLATFORM}" "vers=${VERSION}" "refspec=${SAMBA_BRANCH}" | ||
| make "test.rpms.${PLATFORM}" "vers=${VERSION}" "refspec=${SAMBA_BRANCH}" |
There was a problem hiding this comment.
I was expecting to see make rpms.${PLARFORM} instead of an if/else branching.
Doesn't keeping the if/else branch defeat the purpose of this PR and the preparatory samba-build PR?
I suggest to remove the if-else branch and only use make rpms.${PLATFORM} directly.
There was a problem hiding this comment.
I was not looking right, confused removal with addition. forget this review...
obnoxxx
approved these changes
Jul 23, 2024
| make "test.rpms.${PLATFORM}${VERSION}" "refspec=${SAMBA_BRANCH}" | ||
| fi | ||
| make "rpms.${PLATFORM}" "vers=${VERSION}" "refspec=${SAMBA_BRANCH}" | ||
| make "test.rpms.${PLATFORM}" "vers=${VERSION}" "refspec=${SAMBA_BRANCH}" |
There was a problem hiding this comment.
I was not looking right, confused removal with addition. forget this review...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With samba-in-kubernetes/samba-build#48 we combine version specific build targets for CentOS using a general makefile rule.
depends on samba-in-kubernetes/samba-build#48