-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Samba-operator crashes when setting affinity in clustered samba server #330
Comments
synarete
added a commit
to synarete/samba-operator
that referenced
this issue
Feb 29, 2024
Protect from case where user provided 'affinity' entry in podSettings of smbcommonconfig but without 'podAntiAffinity' sub-entry. This in turn would cause samba-operator a nil pointer dereference. Fixes: samba-in-kubernetes#330 Signed-off-by: Shachar Sharon <ssharon@redhat.com>
Try with this fix: #331 |
mergify bot
pushed a commit
that referenced
this issue
Mar 4, 2024
Protect from case where user provided 'affinity' entry in podSettings of smbcommonconfig but without 'podAntiAffinity' sub-entry. This in turn would cause samba-operator a nil pointer dereference. Fixes: #330 Signed-off-by: Shachar Sharon <ssharon@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reproduce:
Causes:
According to the logs, samba-operator reports error at func buildOneSmbdPerNodeAffinity(). When affinity is set, affinity.PodAntiAffinity may still be null if this attribute is not set in smbcommonconfig. Currently a workaround is adding affinity.PodAntiAffinity with empty list in the yaml file.
The text was updated successfully, but these errors were encountered: