make check updates to cope with oldest stable version go1.22
#345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoopcs9
force-pushed
the
update-golangci-lint
branch
from
80aa8ff
to
ebf80e5
Compare
anoopcs9
changed the title
golangci-lint and gosec versions
anoopcs9
changed the title
golangci-lint and gosec versionsmake check updates to cope with oldest stable version go1.22
synarete
previously approved these changes
Aug 22, 2024
- The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar. - The linter named \"megacheck\" is deprecated. It has been split into: gosimple, staticcheck, unused. - The configuration option `linters.govet.check-shadowing` is deprecated. Please enable `shadow` instead, if you are not using `enable-all`. Also fixes all occurrence of "Error: printf: non-constant format string in call to fmt.Errorf (govet)" error. Signed-off-by: Anoop C S <anoopcs@samba.org>
Updating gosec to avoid the panic raised with go1.22. Signed-off-by: Anoop C S <anoopcs@samba.org>
go1.23 is now available making go1.22 the oldest supported release. We should now update the Dockerfile accordingly to make go-version-check.sh happy. Signed-off-by: Anoop C S <anoopcs@samba.org>
anoopcs9
force-pushed
the
update-golangci-lint
branch
from
cfd57a6
to
2f5f089
Compare
Added the new/replaced linter
|
phlogistonjohn
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go1.23 has been released which demands updates to various components.
golangci-lint
make check#344 which should be fixed with latest golangci-lint versions.linters.govet.check-shadowingis deprecated. Please enableshadowinstead, if you are not usingenable-all.govethappy.gosec
We happened to observe the panic from the linked issue #344 which should be fixed with latest gosec versions.
go-version-check.sh
Update Dockerfile to reflect the oldest stable version go1.22 so as to pass
make check-dockerfile-go-version.fixes #344