-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sit.cephfs: Add share configured with vfs_ceph_new
(non-mgr)
#116
Conversation
I think instead of adding a new variable, we should just add to the list of variants. "vfs_new"? |
There are multiple aspects to be considered here:
Let me know if you had something else in your mind. |
I think I'll reverse the order here to first make the change to group possible shares(starting with cephfs) and then rework this PR to add another share(using vfs_ceph_new) on top of it. |
I think the code is far too complex now with a number of if conditions causing it to split into multiple code paths. This change adds another such conditions. I think it would be far easier to go straight to grouping now. |
vfs_ceph_new
vfs_ceph_new
|
43f75e1
to
89271ac
Compare
/retest centos-ci/xfs |
vfs_ceph_new
vfs_ceph_new
(non-mgr)
🎉 All dependencies have been resolved ! |
Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
The merge-base changed after approval.
depends on #117