improved main #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log general info early on upon process boot; in particular, version and git-revision info. Useful for debugging. Fixed also minor revive warn: have comment to top-level main package. Signed-off-by: Shachar Sharon <ssharon@redhat.com>
synarete
force-pushed
the
ss-main-improved
branch
2 times, most recently
from
5b84d63
to
529bb31
Compare
Use helper function to create clientset for communication with k8s api server. Try first to use in-cluster config, and only if fails use out-of-cluster mode. If user did not provide explicit KUBECONFIG, try to use the default well-known location at "$HOME/.kube/config". Signed-off-by: Shachar Sharon <ssharon@redhat.com>
Use different exit-codes for failures upon boot sequence, so that container failure cause may be detected quickly by its exit code. Signed-off-by: Shachar Sharon <ssharon@redhat.com>
Make revive happy or else CI will fail. Signed-off-by: Shachar Sharon <ssharon@redhat.com>
synarete
force-pushed
the
ss-main-improved
branch
from
529bb31
to
8b031ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align
mainconventions withsamba-operator.