docs: add release process document #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlogistonjohn
force-pushed
the
jjm-release-doc
branch
from
a6497be
to
2707c56
Compare
synarete
approved these changes
Aug 3, 2023
docs/release-process.md
Outdated
| ``` | ||
|
|
||
| Note that the base images are expected to change over time. Make sure | ||
| you pull the images that are used by the project's Dockerfile. |
There was a problem hiding this comment.
Change: Dockerfile --> Containerfile
There was a problem hiding this comment.
Fixed, thanks.
| Log in to quay.io. | ||
|
|
||
| Push the image using the temporary pre-release tag: | ||
| ``` |
There was a problem hiding this comment.
Add:
podman login quay.io
...
2707c56
to
34ef0c3
Compare
anoopcs9
suggested changes
Aug 4, 2023
docs/release-process.md
Outdated
| Wait for the security scan to complete. There shouldn't be any issues if you | ||
| properly updated the base images before building. If there are issues and you | ||
| are sure you used the newest base images, check the base images on quay.io and | ||
| make sure the number of issues are are identical. The security scan can take |
There was a problem hiding this comment.
Suggested change
| make sure the number of issues are are identical. The security scan can take | |
| make sure that number of issues are identical. The security scan can take |
There was a problem hiding this comment.
The double are needs to be fixed. But I don't think that the other part of the fix is grammatical. I think "that the" would be OK though.
docs/release-process.md
Outdated
| release is unremarkable (e.g. few changes occurred since the previous release). | ||
|
|
||
| Because this is a container based release we do not provide any build artifacts | ||
| on GitHub (beyond the sources automatically provided there). Instead we we add |
There was a problem hiding this comment.
Suggested change
| on GitHub (beyond the sources automatically provided there). Instead we we add | |
| on GitHub (beyond the sources automatically provided there). Instead we add |
Signed-off-by: John Mulligan <jmulligan@redhat.com>
phlogistonjohn
force-pushed
the
jjm-release-doc
branch
from
34ef0c3
to
9199cf4
Compare
anoopcs9
approved these changes
Aug 4, 2023
|
And merged months later in November. 🐌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally, I've gotten around to documenting the release process based on my notes from the release in June.