pin puppeteer version to v1.3.0, to match the bundled headless chrome v67 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mglasgow
changed the title
|
It can be fixed until version 1.11.0. Just commenting for people facing this issue. More info about it puppeteer/puppeteer#1409 |
|
My latest PR upgrades support for nodejs v12, and as a result can use any puppeteer version available. See #47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I downloaded a fresh copy of this starter kit and tried to run it. In AWS, it timed out. Puppeteer versions later than 1.3.0 expect a more recent version of chrome than the v67 that is bundled in the repo at the moment. This mismatch of puppeteer version causes the starter kit to appear to hang on the page.newPage() call.
By pining the version to v1.3.0 of puppeteer, the starter kit works again.
I am going to create some more pull requests next to upgrade the starter kit to nodejs v8.10, now that v6.10 on AWS Lambda will be end of life by 30 April 2019. Reference: apex/up#763.
I will also create a pull request to use the chrome binary from https://github.com/alixaxel/chrome-aws-lambda, as this binary is created in lock-step with puppeteer releases specifically for AWS lambda.
I'm breaking these changes up into multiple pull requests to keep them small and easy to comprehend.