Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedisOutOfConfiguredMaxmemory: checking if memory limit is set #410

Merged
merged 1 commit into from
May 2, 2024

Conversation

shtoltz
Copy link
Contributor

@shtoltz shtoltz commented May 2, 2024

If memory limit for Redis instance is not set then redis_memory_max_bytes metric equals 0 - https://github.com/oliver006/redis_exporter?tab=readme-ov-file#the-redis_memory_max_bytes-metric

In that case expression redis_memory_used_bytes / redis_memory_max_bytes * 100 > 90 return +Inf that fires RedisOutOfConfiguredMaxmemory alert.

So we additionally need to check redis_memory_max_bytes > 0 condition

@shtoltz shtoltz force-pushed the redis_check_memory_limit_set branch from 1a0f1f1 to 5414b53 Compare May 2, 2024 15:42
@samber
Copy link
Owner

samber commented May 2, 2024

thanks for the fix!

@samber samber merged commit aad1c4c into samber:master May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants