Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HaproxyBackendMaxActiveSession: look at current / limit #413

Merged
merged 1 commit into from
May 13, 2024

Conversation

fschlich
Copy link
Contributor

haproxy_backend_max_sessions is the maximum number of sessions ever encountered during the lifetime of the HAProxy process. That is, it will never go down until HAProxy is restarted, so the alert continues to fire even though the situation has cleared!

This doesn't make sense. Look at the currently active sessions instead.

haproxy_backend_max_sessions is the maximum number of sessions ever encountered during the lifetime of the HAProxy process. That is, it will never go down until HAProxy is restarted, so the alert continues to fire even though the situation has cleared!

This doesn't make sense. Look at the currently active sessions instead.
@samber samber merged commit 396083a into samber:master May 13, 2024
@samber
Copy link
Owner

samber commented May 13, 2024

Thanks for the fix and welcome in the contributors \o/

@DonPerinon
Copy link
Contributor

The question is, what is the actual purpose of this alert? One possible use is certainly the detection of connection limits. However, in this setting, we will probably lose the ability to detect the peak number of connections if we adjust it between scraping intervals. But it likely depends on what the alert is used for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants