New helpers for concurrency: lo.Timeout + lo.Deadline + lo.Race #267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
func Timeout(duration time.Duration, callback func(done func())) error
func Deadline(duration time.Time, callback func(done func())) error
func Race(callbacks ...func(done func()))
Timeout and Deadline should not be used when a context is available.
I'm not really sure
Timeout
andDeadline
should be added to this library, sincecontext.WithTimeout
andcontext.WithDeadline
are highly recommended.For all helpers,
isDone func() bool
might be passed to callbacks.Should we add a timeout/deadline to
lo.Race()
? More helperslo.RaceWithTimeout()
lo.RaceWithDeadline()
?Should
lo.Race()
return anything ?WDYT ?