Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: driver.Valuer implementation on Option #34

Closed
wants to merge 1 commit into from

Conversation

angelbirth
Copy link

I encountered a bug where the driver couldn't derive the type of Option[uint32]. Go has driver.DefaultParameterConverter that returns the correct Value, therefore I delegated the Option.Value method to driver.DefaultParameterConverter.ConvertValue

@samber
Copy link
Owner

samber commented Oct 16, 2023

Thanks, can you add a unit test please ?

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (77f2b29) 89.15% compared to head (bcdc8e4) 89.15%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   89.15%   89.15%           
=======================================
  Files          13       13           
  Lines        1125     1125           
=======================================
  Hits         1003     1003           
  Misses        109      109           
  Partials       13       13           
Flag Coverage Δ
unittests 89.15% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
option.go 89.87% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@angelbirth
Copy link
Author

I will try. Can I use existing tests as reference?

@samber
Copy link
Owner

samber commented Jul 16, 2024

Sorry for the delay in my response.

-> v1.13.0

@samber samber closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants