fix: replace trace-id by trace_id

spec: https://opentelemetry.io/docs/specs/otel/compatibility/logging_trace_context
samber · Aug 17, 2024 · c8628d6 · c8628d6
1 parent 85dd438
commit c8628d6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -111,8 +111,8 @@ Attributes will be injected in log payload.
 Other global parameters:
 
 ```go
-slogecho.TraceIDKey = "trace-id"
-slogecho.SpanIDKey = "span-id"
+slogecho.TraceIDKey = "trace_id"
+slogecho.SpanIDKey = "span_id"
 slogecho.RequestBodyMaxSize  = 64 * 1024 // 64KB
 slogecho.ResponseBodyMaxSize = 64 * 1024 // 64KB
 slogecho.HiddenRequestHeaders = map[string]struct{}{ ... }

diff --git a/middleware.go b/middleware.go
@@ -18,8 +18,8 @@ const (
 )
 
 var (
-	TraceIDKey   = "trace-id"
-	SpanIDKey    = "span-id"
+	TraceIDKey   = "trace_id"
+	SpanIDKey    = "span_id"
 	RequestIDKey = "id"
 
 	RequestBodyMaxSize  = 64 * 1024 // 64KB
@@ -308,6 +308,7 @@ func NewWithConfig(logger *slog.Logger, config Config) echo.MiddlewareFunc {
 	}
 }
 
+// AddCustomAttributes adds custom attributes to the request context.
 func AddCustomAttributes(c echo.Context, attr slog.Attr) {
 	v := c.Get(customAttributesCtxKey)
 	if v == nil {