Ban yarn berry on setup manager.
#652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anged setup wizard of `nestia` to define `npm postinstall` script instead. By the way, unlike the `npm prepare` script which works on only in the local drive and does not work when be installed from remote `npm`, `npm postinstall` script is working even when installing from the remote `npm`. Therefore, when publishing an `npm` module which has installed `tyipa` through setup wizard, it enforces users of derived libraries to run the `npm postinstall` command that requires `ts-patch` module. To fix this crazy bug, I've decided to ban `yarn berry` on the setup wizard. From now on, when you run the `npx nestia setup` command, it will print a text that "yarn berry is not supported". If you still want to utilize the `yarn berry`, configure it manually by yourself please.
samchon
added
bug
samchon
changed the title
yarn berry which had banned npm prepare script, I'd ch…yarn berry on setup manager.
When `@nestia/migrate` being runned, it could not analyze `*/*` content type, because I hadn't known that such crazy content-type could be written. By the way, as I've identified it, I've decided to consider it as a `application/json` content type.
samchon
added a commit
that referenced
this pull request
Oct 12, 2023
I've banned `yarn berry` which does not support `npm prepare` command to change setup wizard to using the standard `npm prepare` command. By the way, SDK distribution composer had determined whether the target distribution directory has been prepared by checking the `package.json` file with the `npm run prepare` command. Therefore, if the SDK distrubition directory being composed by older version of `@nestia/sdk`, newer version's SDK distribution composer re-composed the distribution directory vulnerably. This PR fixes such bug.
samchon
added a commit
that referenced
this pull request
Oct 12, 2023
Complement #652 - fix bug of SDK distrubition composer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support
yarn berrywhich had bannednpm preparescript, I'd changed setup wizard ofnestiato definenpm postinstallscript instead.By the way, unlike the
npm preparescript which works on only in the local drive and does not work when be installed from remotenpm,npm postinstallscript is working even when installing from the remotenpm. Therefore, when publishing annpmmodule which has installedtyipathrough setup wizard, it enforces users of derived libraries to run thenpm postinstallcommand that requirests-patchmodule.To fix this crazy bug, I've decided to ban
yarn berryon the setup wizard. From now on, when you run thenpx nestia setupcommand, it will print a text that "yarn berry is not supported". If you still want to utilize theyarn berry, configure it manually by yourself please.