Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Equal type of Comparison of equivalence #1167

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

kakasoo
Copy link
Contributor

@kakasoo kakasoo commented Jul 17, 2024

The existing Equal type did not work for the union type. For a more complete type comparison, it is recommended to use the Equal type separately as a separate file.

@samchon samchon added enhancement New feature or request good first issue Good for newcomers labels Jul 17, 2024
Copy link

pkg-pr-new bot commented Jul 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 8db3cff

typia

npm i https://pkg.pr.new/typia@1167


templates

Copy link
Owner

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would better to propert description comment, and add export keyword.

Also, what about importing the Equal type in below files?:

  • Primitive
  • Resolved
  • CamelCase
  • PascalCase
  • SnakeCase

Copy link
Owner

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good type.

@samchon samchon merged commit a656281 into samchon:master Jul 18, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants