Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): update node versions #1414

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

ryoppippi
Copy link
Contributor

@ryoppippi ryoppippi commented Dec 3, 2024

In this patch

  • use 'lts' version for pkg-pr-new & bun action
  • added multiple node version matrix for Node action

for now, lts/* means 22.x, so if you think
node-version: [20.x, 22.x, lts/*]
is redundant, you can fix that part

Copy link

pkg-pr-new bot commented Dec 3, 2024

Open in Stackblitz

npm i https://pkg.pr.new/typia@1414

commit: a2cd549

Copy link
Owner

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution.

By the way, as typia does not have native feature especially requiring NodeJS version up, I think this PR is much suitable for my another project nestia. Would you contribute same PR to the nestia?

Always thanks for endless contributions.

@samchon samchon merged commit 0e7b90a into samchon:master Dec 13, 2024
9 checks passed
@ryoppippi ryoppippi deleted the feature/ci branch December 13, 2024 02:11
@ryoppippi
Copy link
Contributor Author

@samchon in that case, do we still need only lts/ ?

@samchon
Copy link
Owner

samchon commented Dec 13, 2024

Let's just keep this PR. No reason to rolling back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants