Close #823 - ban Map types on JSON functions. #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `JSON.stringify()` function be called about `Map<Key, T>` type, it always returns the empty bracket value `{}`. Until now, I'd developed `typia` to return the empty bracket value `{}`, following the standard `JSON.stringify()` function.
However, as most TypeScript/JavaScript developers do not know about that and there's not any problem when using the `Map` type on `typia.json.stringify<T>()` function ini the compile time, it was possible to misunderstand that `typia`'s stringify function has a bug about the `Map` time.
In such reason, I've decided to throw a compile error when such non-supported type being used in the `typia.json` functions. Also, such strategy would be helpful for `typia` users to avoid taking a mistake using such non-supported type on the JSON functions.
samchon
added a commit
to samchon/nestia
that referenced
this pull request
Oct 12, 2023
In such reason, `typia` banned `Map` types on the JSON related functions. Following the policy of `typia`, `nestia` also bands such unsupported types on the JSON related functions.
> When `JSON.stringify()` function be called about `Map<Key, T>` type, it always returns the empty bracket value `{}`. Until now, I'd developed `typia` to return the empty bracket value `{}`, following the standard `JSON.stringify()` function.
>
> However, as most TypeScript/JavaScript developers do not know about that and there's not any problem when using the `Map` type on `typia.json.stringify<T>()` function ini the compile time, it was possible to misunderstand that `typia`'s stringify function has a bug about the `Map` time.
>
> In such reason, I've decided to throw a compile error when such non-supported type being used in the `typia.json` functions. Also, such strategy would be helpful for `typia` users to avoid taking a mistake using such non-supported type on the JSON functions.
- Related PR of `typia`: samchon/typia#844
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
JSON.stringify()function be called aboutMap<Key, T>type, it always returns the empty bracket value{}. Until now, I'd developedtypiato return the empty bracket value{}, following the standardJSON.stringify()function.However, as most TypeScript/JavaScript developers do not know about that and there's not any problem when using the
Maptype ontypia.json.stringify<T>()function ini the compile time, it was possible to misunderstand thattypia's stringify function has a bug about theMaptime.In such reason, I've decided to throw a compile error when such non-supported type being used in the
typia.jsonfunctions. Also, such strategy would be helpful fortypiausers to avoid taking a mistake using such non-supported type on the JSON functions.