Fix ESM importing on Node.js #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Yeah, ES module ecosystem is still a mess.) Read node.js - Typescript packages that ship with .mjs and .d.ts, but without .d.mts - how to import with ESM enabled? - Stack Overflow and Dual ESM/CJS emit with tsc · Issue #54593 · microsoft/TypeScript for the dirty details... |
Currently, Node.js always used the CommonJS version even when imported from an ES module. That's because ES modules require an `exports` key to be defined in `package.json`. (The `module` key is only used by bundlers, AFAIK.) Also, since there is no `type: "module"` configured, all ES modules need to have the `.mjs` extension (otherwise they will go through the CommonJS compatibility shim which again, will cause the import to fail). Fix that as well.
samchungy
approved these changes
Jan 30, 2024
|
Thanks for the contribution! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Node.js always used the CommonJS version even when imported from an ES module. That's because ES modules require an
exportskey to be defined inpackage.json.(The
modulekey is only used by bundlers, AFAIK.)Also, since there is no
type: "module"configured, all ES modules need to have the.mjsextension (otherwise they will go through the CommonJS compatibility shim which again, will cause the import to fail). Fix that as well.